Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support User Provisioned Envoy Proxy fleet #1379

Open
arkodg opened this issue Apr 28, 2023 · 4 comments
Open

Support User Provisioned Envoy Proxy fleet #1379

arkodg opened this issue Apr 28, 2023 · 4 comments
Labels
help wanted Extra attention is needed kind/enhancement New feature or request
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Apr 28, 2023

Description:
It is hard to support all Kubernetes knobs for Deployment and Service within our EnvoyProxy API to customize EnvoyProxy Fleet resources, so its easier to allow users to create and update the envoy proxy fleet themselves, and use Envoy Gateway only to retrieve Xds Configuration

Here are the following things we need to do if this is something we want to support

  • Disable the Infra Manager and support User Provisioned Envoy Proxy fleet
  • Provide helm charts to create the Envoy Fleet resources (Service, Deployment)
  • Add helm knobs to specify
    • Xds Server URL
    • TLS Credentials
    • Labels for Envoy Deployment and Service
@qicz
Copy link
Member

qicz commented Apr 29, 2023

IMO, supporting user-provisioned fleet, it is hard to config the XDS server and it would be inconvenient to extend more features. how we can support Wasm?

the infra manager can manage the envoy proxy easily.

support all Kubernetes knobs for Development and Service is hard but we can keep the frequently-used knobs only.

@arkodg
Copy link
Contributor Author

arkodg commented Apr 29, 2023

this is not ideal from the project perspective since its another layer of customizations/support burden but it seems to be something many users want

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@arkodg
Copy link
Contributor Author

arkodg commented Aug 7, 2023

with this approach, some features such as EnvoyProxy.Spec.Telemetry.Metrics would need to be caveated since those fields edit the bootstrap file in Envoy https://github.com/envoyproxy/gateway/blob/main/internal/xds/bootstrap/bootstrap.yaml.tpl which EG might not have access to for this BYO case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants