make Reconcile only when related Resources changed

[spwangxp]

Description:

if a cr httproute changed, envoyproxy shouldn't be build and compare, just need sync the rule. it's will make logical clear and easy to maintain.

[spwangxp]

@qicz

[qicz]

@qicz

thanks @spwangxp I will fix this

[arkodg]

is this a regression ?
imo this shouldnt be happening if the InfraIR content is not changing

gateway/internal/infrastructure/runner/runner.go

Line 65 in 24df11e

} else {

gets called (Update) only when the value within InfraIR has changed

[arkodg]

nvm, this is a performance optimization in the provider layer to reduce the k8s List calls for EnvoyProxy .

gateway/internal/provider/kubernetes/controller.go

Line 231 in 29995bd

if err := r.processParamsRef(ctx, acceptedGC, resourceTree); err != nil {

can be selectively called/computed only if the Name, Namespace & ObservedGeneration within the EnvoyProxy within the resourceTree has changed

[arkodg]

relates to #1365

[qicz]

is this a regression ? imo this shouldnt be happening if the InfraIR content is not changing

gateway/internal/infrastructure/runner/runner.go

Line 65 in 24df11e

} else {

gets called (Update) only when the value within InfraIR has changed

It is right, but the controller did more unnecessary processing

[qicz]

nvm, this is a performance optimization in the provider layer to reduce the k8s List calls for EnvoyProxy .

gateway/internal/provider/kubernetes/controller.go

Line 231 in 29995bd

if err := r.processParamsRef(ctx, acceptedGC, resourceTree); err != nil {

can be selectively called/computed only if the Name, Namespace & ObservedGeneration within the EnvoyProxy within the resourceTree has changed

IMO, we should check all Kind that the controller watched in resourceTree

[arkodg]

thinking again, this might be a premature optimization because, the contents from List should be cached

[qicz]

thinking again, this might be a premature optimization because, the contents from List should be cached

yep, the watchable.Map just handle the change. check that all Kinds are compared resourceTree and the k8s stored.

the compare logic is a matter of course. cc @spwangxp

[spwangxp]

ok, got it. thx!

[qicz]

close this issue now.

if you have another issue pls raise it. thanks @spwangxp