Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedup code pertaining to xRoute using reflection #1252

Closed
arkodg opened this issue Apr 3, 2023 · 4 comments · Fixed by #1502
Closed

Dedup code pertaining to xRoute using reflection #1252

arkodg opened this issue Apr 3, 2023 · 4 comments · Fixed by #1502
Assignees
@shawnh2
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. kind/refactor no stalebot
Milestone
0.5.0-rc1

Comments

@arkodg
Copy link
Contributor

arkodg commented Apr 3, 2023

Description:
There is a lot of code in https://github.com/envoyproxy/gateway/blob/main/internal/gatewayapi/contexts.go and https://github.com/envoyproxy/gateway/blob/main/internal/gatewayapi/route.go that could be deduplicated using reflection https://pkg.go.dev/reflect
@arkodg arkodg added help wanted Extra attention is needed area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. labels Apr 3, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Apr 9, 2023

I can work on it in v0.5.0 : )

@Xunzhuo Xunzhuo self-assigned this Apr 9, 2023
@Xunzhuo Xunzhuo added kind/refactor and removed help wanted Extra attention is needed labels Apr 9, 2023
@arkodg arkodg added this to the 0.5.0-rc1 milestone Apr 10, 2023
@github-actions github-actions bot added the stale label May 10, 2023
@envoyproxy envoyproxy deleted a comment from github-actions bot May 10, 2023
@Xunzhuo Xunzhuo added no stalebot help wanted Extra attention is needed and removed stale labels May 10, 2023
@Xunzhuo Xunzhuo removed their assignment May 13, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented May 13, 2023

I will unassign this one for recent I am lack of bandwidth.

@shawnh2
Copy link
Contributor

shawnh2 commented Jun 5, 2023 •
edited
Loading

hi, i can work on this issue, assign plz

@arkodg
Copy link
Contributor Author

arkodg commented Jun 5, 2023

thanks @shawnh2 !

@arkodg arkodg removed the help wanted Extra attention is needed label Jun 5, 2023
@shawnh2 shawnh2 mentioned this issue Jun 7, 2023
Merged
@cnvergence cnvergence mentioned this issue Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnh2 shawnh2

Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. kind/refactor no stalebot
Projects
None yet
Milestone
0.5.0-rc1
Development

Successfully merging a pull request may close this issue.

refactor: dedup the route context code using reflection shawnh2/gateway
3 participants
@arkodg @shawnh2 @Xunzhuo