Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestServeXdsServerListenFailed panics when make test #1204

Closed
Xunzhuo opened this issue Mar 23, 2023 · 8 comments · Fixed by #1215
Closed

TestServeXdsServerListenFailed panics when make test #1204

Xunzhuo opened this issue Mar 23, 2023 · 8 comments · Fixed by #1215
Labels
kind/bug Something isn't working

Comments

@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 23, 2023

I am using darwin/arm64, running make test will panic like:

image
@Xunzhuo Xunzhuo added the kind/bug Something isn't working label Mar 23, 2023
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Mar 23, 2023

cc @muyuan0

@muyuan0
Copy link
Contributor

muyuan0 commented Mar 23, 2023

Maybe it is relative to agiledragon/gomonkey#10.
Would you try the solution at https://github.com/eisenxp/macos-golink-wrapper?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Mar 24, 2023 •
edited
Loading

I think adding this testcase brought less meaning but make it hard for local development, we cannot let every contributor who is using mac to set it up like this way. I always make test before sending a PR.

cc @arkodg @zirain

@Xunzhuo Xunzhuo changed the title TestServeXdsServerListenFailed panics in local TestServeXdsServerListenFailed panics whenmake test Mar 24, 2023
@Xunzhuo Xunzhuo changed the title TestServeXdsServerListenFailed panics whenmake test TestServeXdsServerListenFailed panics when make test Mar 24, 2023
@zirain
Copy link
Contributor

zirain commented Mar 24, 2023

I will try on darwin/amd64 later.

@zirain
Copy link
Contributor

zirain commented Mar 24, 2023

I will try on darwin/amd64 later.

passed on darwin/amd64

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Mar 24, 2023

Looks like only not work in darwin arm64.

@arkodg
Copy link
Contributor

arkodg commented Mar 24, 2023 •
edited
Loading

can we skip this test for darwin/arm64, if that is non trivial, we can then consider removing it

@muyuan0
Copy link
Contributor

muyuan0 commented Mar 25, 2023 •
edited
Loading

Let me find a way to test it without gomonkey this weekend.

@muyuan0 muyuan0 mentioned this issue Mar 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test serveXdsServer failed to listen without gomonkey muyuan0/gateway
4 participants
@zirain @arkodg @Xunzhuo @muyuan0