Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: envoyproxy/gateway
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e3180acb2ed1f6353695d4784e96eb4a391ff49f
Choose a base ref
..
head repository: envoyproxy/gateway
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8a8e841bddc3e74bdff739cfcad2cc0ca97807a3
Choose a head ref
Showing with 3 additions and 3 deletions.
  1. +3 −3 internal/xds/translator/oidc.go
6 changes: 3 additions & 3 deletions internal/xds/translator/oidc.go
Original file line number Diff line number Diff line change
@@ -94,7 +94,7 @@ func buildHCMOAuth2Filter(route *ir.HTTPRoute) (*hcmv3.HttpFilter, error) {
}

func oauth2FilterName(route *ir.HTTPRoute) string {
return fmt.Sprintf("%s_%s", oauth2Filter, route.Name)
return perRouteFilterName(oauth2Filter, route.Name)
}

func oauth2Config(route *ir.HTTPRoute) (*oauth2v3.OAuth2, error) {
@@ -340,8 +340,8 @@ func (*oidc) patchRoute(route *routev3.Route, irRoute *ir.HTTPRoute) error {
if irRoute.OIDC == nil {
return nil
}

if err := enableFilterOnRoute(route, irRoute.Name); err != nil {
filterName := oauth2FilterName(irRoute)
if err := enableFilterOnRoute(route, filterName); err != nil {
return err
}
return nil