From f2c8b77c07c986be8b259e27bb922dc5e06f4514 Mon Sep 17 00:00:00 2001 From: Huabing Zhao Date: Wed, 6 Nov 2024 10:00:29 +0800 Subject: [PATCH] fix: push a helm chart without v in ther version (#4636) * push a helm chart without v in ther version Signed-off-by: Huabing Zhao * rename tag Signed-off-by: Huabing Zhao --------- Signed-off-by: Huabing Zhao --- .github/workflows/build_and_test.yaml | 1 + .github/workflows/release.yaml | 2 ++ release-notes/current.yaml | 1 + 3 files changed, 4 insertions(+) diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml index 92ae1b4822d..10375375d46 100644 --- a/.github/workflows/build_and_test.yaml +++ b/.github/workflows/build_and_test.yaml @@ -224,3 +224,4 @@ jobs: # use `0.0.0` as the default latest version. # use `Always` image pull policy for latest version. run: IMAGE_PULL_POLICY=Always OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=v0.0.0-latest TAG=latest make helm-push + run: IMAGE_PULL_POLICY=Always OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=0.0.0-latest TAG=latest make helm-push diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index feec5902af6..8e792355d10 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -57,6 +57,7 @@ jobs: shell: bash run: | echo "release_tag=$(echo ${GITHUB_REF##*/})" >> $GITHUB_ENV + echo "without_v_release_tag=${release_tag:1}" >> $GITHUB_ENV echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_ENV - name: Login to DockerHub @@ -73,6 +74,7 @@ jobs: - name: Build and Push EG Release Helm Chart run: IMAGE_PULL_POLICY=IfNotPresent OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=${{ env.release_tag }} IMAGE=docker.io/envoyproxy/gateway TAG=${{ env.release_tag }} make helm-package helm-push + run: IMAGE_PULL_POLICY=IfNotPresent OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=${{ env.without_v_release_tag }} IMAGE=docker.io/envoyproxy/gateway TAG=${{ env.release_tag }} make helm-package helm-push - name: Download Benchmark Report uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 diff --git a/release-notes/current.yaml b/release-notes/current.yaml index 3b54de7121e..3795a8b2fb9 100644 --- a/release-notes/current.yaml +++ b/release-notes/current.yaml @@ -18,6 +18,7 @@ bug fixes: | The xDS translation failed when wasm http code source configured without a sha HTTPRoute status only shows one parent when targeting multiple Gateways from different GatewayClasses Route with multiple parents has incorrect namespace in parentRef status + Helm chart fails for Flux HelmRelease # Enhancements that improve performance. performance improvements: |