Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Add the ability to set the stream idle timeout in Cronvoy #33827

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

abeyad
Copy link
Contributor

@abeyad abeyad commented Apr 26, 2024

No description provided.

@abeyad
Copy link
Contributor Author

abeyad commented Apr 26, 2024

/assign @fredyw

@abeyad abeyad enabled auto-merge (squash) April 26, 2024 21:34
@RenjieTang
Copy link
Contributor

Could you please point me to the code where this timeout triggers connection close?

@abeyad abeyad merged commit 81c6142 into envoyproxy:main Apr 26, 2024
35 checks passed
@abeyad
Copy link
Contributor Author

abeyad commented Apr 27, 2024

Could you please point me to the code where this timeout triggers connection close?

filter_manager_.streamInfo().setResponseFlag(StreamInfo::CoreResponseFlag::StreamIdleTimeout);
and
stream_info_.setResponseFlag(StreamInfo::CoreResponseFlag::StreamIdleTimeout);

@abeyad abeyad deleted the stream-idle-timeout-builder branch April 27, 2024 01:26
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants