Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 4.0.0 #9412

Closed
bazel-flag-bot opened this issue Dec 19, 2019 · 3 comments
Assignees
Labels
area/build no stalebot Disables stalebot from closing an issue

Comments

@bazel-flag-bot
Copy link

Incompatible flag --incompatible_restrict_string_escapes will break Envoy once Bazel 1.2.1 is released.

Please see the following CI builds for more information:

Questions? Please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.

@mattklein123 mattklein123 added area/build no stalebot Disables stalebot from closing an issue labels Dec 19, 2019
@mattklein123 mattklein123 added this to the 1.14.0 milestone Dec 19, 2019
@mattklein123 mattklein123 modified the milestones: 1.14.0, 1.15.0 Mar 10, 2020
@lizan
Copy link
Member

lizan commented Apr 21, 2020

blocked by bazel-contrib/rules_foreign_cc#331 which blocks us upgrading rules_foreign_cc.

@lizan
Copy link
Member

lizan commented Apr 21, 2020

bazelbuild/bazel#8380 is the flag flip issue.

@lizan lizan changed the title Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 1.2.1 Flag --incompatible_restrict_string_escapes will break Envoy in Bazel 4.0.0 Apr 21, 2020
@mattklein123 mattklein123 removed this from the 1.15.0 milestone Jun 17, 2020
@lizan
Copy link
Member

lizan commented Jul 8, 2020

Fixed by #11520

@lizan lizan closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

3 participants