Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response_headers_to_add for Envoy-generated error responses #8944

Open
ascheglov opened this issue Nov 8, 2019 · 2 comments
Open

Use response_headers_to_add for Envoy-generated error responses #8944

ascheglov opened this issue Nov 8, 2019 · 2 comments
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@ascheglov
Copy link
Contributor

On events like a request timeout, Envoy sends a locally generated response (the sendLocalReply function). But it doesn't use the response_headers_to_add config option. Which could be useful when response_headers_to_add has some diagnostic information (e.g. the %REQ(x-request-id)% which was added in #8683)

We can fix this by adding finalizeResponseHeaders calls before sendLocalReply calls, in functions like onUpstreamAbort.

@snowp snowp added the enhancement Feature requests. Not bugs or questions. label Nov 8, 2019
@mattklein123 mattklein123 added the help wanted Needs help! label Nov 8, 2019
@lizan
Copy link
Member

lizan commented Nov 13, 2019

Wondering whether the local reply mapper can address this, basically it will allow you to customize all Envoy-generated error responses. See #8921

@Keramblock
Copy link

Is there any news about it? We need that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

5 participants