Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percentage based retry circuit breaker #8727

Closed
mattklein123 opened this issue Oct 22, 2019 · 1 comment · Fixed by #9069
Closed

Percentage based retry circuit breaker #8727

mattklein123 opened this issue Oct 22, 2019 · 1 comment · Fixed by #9069
Assignees
@tonya11en @lexh
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Milestone
1.13.0

Comments

@mattklein123
Copy link
Member

mattklein123 commented Oct 22, 2019 •
edited
Loading

Instead of specifying a fixed number of active retries, we should also allow specifying the retry circuit breaker as a % of currently active requests (potentially w/ a min floor). This would be easier to auto tune assuming the correct setting of active request circuit breakers and adaptive concurrency.
@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue labels Oct 22, 2019
@mattklein123 mattklein123 added this to the 1.13.0 milestone Oct 22, 2019
@mattklein123
Copy link
Member Author

@lexh will implement this with help from @wgallagher

@tonya11en tonya11en mentioned this issue Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonya11en tonya11en

@lexh lexh

Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

upstream: Implement retry concurrency budgets tonya11en/envoy
3 participants
@tonya11en @lexh @mattklein123