Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlier detection needs to log and handle grpc-status sent as trailers #8228

Open
wenbozhu opened this issue Sep 12, 2019 · 6 comments
Open
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@wenbozhu
Copy link

Title: Outlier detection needs to log and handle grpc-status sent as trailers

Description:

Outlier detection currently doesn't check response trailers, which may contain an error grpc-status when a gRPC stream is closed.

Relevant Links:

See the discussion on the original issue for adding grpc-status support in Outlier Detection.

@wenbozhu
Copy link
Author

@cpakulski could you comment on how we may want to fix this? We think this issue is important to fix for gRPC users, i.e. for gRPC-based streaming services.

@louiscryan

@cpakulski
Copy link
Contributor

Sorry, I was away - will comment within a day or two. Thanks!

@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Sep 17, 2019
@rcash
Copy link

rcash commented Oct 29, 2019

Hi @wenbozhu and @cpakulski I'm a student in UT Austin's Virtualization & Containers class. Are you still looking for help in adding support for gRPC response trailers? Thanks!

@wenbozhu
Copy link
Author

We probably need some design inputs from @cpakulski first ...

@htuch

@htuch
Copy link
Member

htuch commented Oct 31, 2019

Yeah, I think if you want to help drive the design here and propose a strawman @rcash that might be a reasonable start.

@cpakulski
Copy link
Contributor

@rcash, @wenbozhu Please look at #7942 as that solved similar case of passing gRPC codes to outlier detector. Let me know if you get stuck in design or understanding the code flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

5 participants