Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: expand linkstamp beyond binary rules. #6859

Open
junr03 opened this issue May 8, 2019 · 2 comments
Open

bazel: expand linkstamp beyond binary rules. #6859

junr03 opened this issue May 8, 2019 · 2 comments
Assignees

Comments

@junr03
Copy link
Member

junr03 commented May 8, 2019

bazel: expand linkstamp beyond binary rules.

Description: linkstamp is currently used by the VersionInfo class to stamp envoy binaries. This is a robust mechanism. However, there are two current problems with it:

  1. It is poorly documented and understood. Document git workspace SHA1 inclusion in C++ builds bazelbuild/bazel#2893
  2. linkstamp is not available for non-binary rules. Thus if the version_info_lib is compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by VersionInfo: allow non-linkstamp rules to link in definitions #6803. However, it would be great to use the same, robust linkstamp mechanism we use for binary rules.
@junr03 junr03 added tech debt no stalebot Disables stalebot from closing an issue labels May 8, 2019
@junr03 junr03 self-assigned this May 8, 2019
@junr03
Copy link
Member Author

junr03 commented May 8, 2019

cc @htuch lmk if this is sufficient for the bazel folks, or if you'd like me to open an issue against bazel.

@htuch
Copy link
Member

htuch commented May 8, 2019

@junr03 it's sufficient for me to share, thanks. I think if we want action on the Bazel front though, it would be good to have a tracking issue in their GH.

@alyssawilk alyssawilk removed the no stalebot Disables stalebot from closing an issue label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants