Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconcile matching throughout Envoy config/API #5569

Open
mattklein123 opened this issue Jan 11, 2019 · 8 comments
Open

reconcile matching throughout Envoy config/API #5569

mattklein123 opened this issue Jan 11, 2019 · 8 comments
Assignees
Labels
api/v3 Major version release @ end of Q3 2019 area/security help wanted Needs help! tech debt

Comments

@mattklein123
Copy link
Member

We have a lot of different matching going on (route, RBAC, Tap, filter chain, etc.) and we probably could share more matching infrastructure across components. This issue tracks figuring out a plan to see what can be shared.

@mergeconflict
Copy link
Member

I have a proposal (now with more detail and fewer owl drawings). I'm hoping to use it as the basis for #6453.

Attn: @mattklein123 @junr03 @htuch.

@htuch
Copy link
Member

htuch commented May 20, 2019

LGTM, I left a few minor comments.

@mattklein123
Copy link
Member Author

In general this LGTM, but I left one comment about when the matchers run. I think this might be problematic in some cases and will need more thinking.

I wonder if it's worth it to have the reference system to begin with vs. just having centralized matching protos and implementation and allowing them to run in different places...

@mattklein123 mattklein123 modified the milestones: 1.11.0, 1.12.0 Jul 3, 2019
@mattklein123 mattklein123 added the api/v3 Major version release @ end of Q3 2019 label Aug 28, 2019
@mattklein123 mattklein123 removed this from the 1.12.0 milestone Aug 28, 2019
@htuch htuch added this to the 1.12.0 milestone Aug 29, 2019
@htuch
Copy link
Member

htuch commented Sep 3, 2019

Within the scope of v4 / UDPA is a more general treatment of matching, see for example the match-action approach in cncf/udpa#4 and https://docs.google.com/document/d/1orxTIL9FXtgmyl5TtPRBqGjgp1ekL7oOKDd95wxeCRY/edit.

@mergeconflict do you have any thoughts on where we might take this at an API level in the scope of v3 (targeted end-of-quarter)? Are there some low hanging fruit we can address now and/or aspects of this that belong in v4 (UDPA)?

@htuch
Copy link
Member

htuch commented Sep 26, 2019

@mattklein123 I'm wondering if we can add the new unified matcher to v2 and then deprecate existing matchers, allowing for their removal in v3. This would be the preferable approach IMHO, rather than a radical change in how matching is done alongside the rest of the v3 work. If that makes sense, do you know who might own this specific task?

@htuch htuch added the help wanted Needs help! label Sep 26, 2019
@mattklein123
Copy link
Member Author

The plan above sounds good, but TBH this is a giant work item and I'm doubtful we are going to find someone to do it. We will probably end up punting to v4 but lets leave help wanted in case someone is interested?

@htuch htuch removed this from the 1.12.0 milestone Sep 26, 2019
@htuch
Copy link
Member

htuch commented Sep 26, 2019

Ack. I've cleared this from the 1.12.0 milestone.

@htuch
Copy link
Member

htuch commented Mar 16, 2020

Related somewhat to #9656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v3 Major version release @ end of Q3 2019 area/security help wanted Needs help! tech debt
Projects
None yet
Development

No branches or pull requests

5 participants