Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set number of workers to allocated cgroup CPUs? #36988

Closed
uhthomas opened this issue Nov 5, 2024 · 3 comments
Closed

Set number of workers to allocated cgroup CPUs? #36988

uhthomas opened this issue Nov 5, 2024 · 3 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@uhthomas
Copy link

uhthomas commented Nov 5, 2024

Title: Set number of workers to allocated cgroup CPUs?

Description:

I noticed that when running envoy in Kubernetes, it sets the number of workers equal to the number of CPUs on the host, even if there is a limit of just 1 CPU. This may negatively impact performance and it would be nice if envoy could pick this up automatically.

[optional Relevant Links:]

golang/go#33803

#5976

@uhthomas uhthomas added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 5, 2024
@KBaichoo
Copy link
Contributor

KBaichoo commented Nov 5, 2024

Have you tried using --cpuset-threads option: https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-cpuset-threads? If the cgroup creates a cpuset I think it might be picked up from that option.

If not the best way to go about this would probably be wrapping the envoy with --concurrency when launching it. It'd be difficult to change the default behavior at this point.

@KBaichoo KBaichoo added question Questions that are neither investigations, bugs, nor enhancements and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 5, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants