Added envoy test missing options for s390x #36915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling envoy test cases by adding missing options for s390x Signed-off-by: Surender Yadav <[email protected]>
|
Hi @surenderky, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
surenderky
changed the title
jwendell
approved these changes
Oct 31, 2024
nezdolik
approved these changes
Nov 1, 2024
|
/assign @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers cannot be assigned to this issue. |
yanavlasov
approved these changes
Nov 5, 2024
surenderky
added a commit
to surenderky/envoy
that referenced
this pull request
Nov 6, 2024
With reference to PR envoyproxy#36915 by mistake added the .cc extension instead of the .h extension. So fixing the extension to options_impl_platform_linux.h. Signed-off-by: Surender Yadav <[email protected]>
ggreenway
pushed a commit
that referenced
this pull request
Nov 6, 2024
With reference to PR #36915 by mistake added the .cc extension instead of the .h extension. So fixing the extension to (options_impl_platform_linux.h). Signed-off-by: Surender Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Enabling envoy test cases by adding missing options for s390x
Additional Description: envoy test cases were enabled for s390x, so included the missing options