Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What will be overridden by retry_budget in config.cluster.v3.CircuitBreakers.Thresholds #30974

Closed
YvesZHI opened this issue Nov 20, 2023 · 3 comments
Labels
area/circuit_breaker question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@YvesZHI
Copy link

YvesZHI commented Nov 20, 2023

I'm reading the doc about the circuit breaker: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/circuit_breaker.proto.html#envoy-v3-api-msg-config-cluster-v3-circuitbreakers-thresholds

There is a note for retry_budget:

If this field is set, the retry budget will override any configured retry circuit breaker.

I can't understand what it means. What will be overridden exactly?

@YvesZHI YvesZHI added the triage Issue requires triage label Nov 20, 2023
@KBaichoo
Copy link
Contributor

I think this this refers to

max_retries:
(UInt32Value) The maximum number of parallel retries that Envoy will allow to the upstream cluster. If not specified, the default is 3.

See original PR: #9069.

@KBaichoo KBaichoo added question Questions that are neither investigations, bugs, nor enhancements area/circuit_breaker and removed triage Issue requires triage labels Nov 20, 2023
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 20, 2023
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/circuit_breaker question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants