Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the upstream receive // path #26055

Closed
qicz opened this issue Mar 13, 2023 · 6 comments
Closed

the upstream receive // path #26055

qicz opened this issue Mar 13, 2023 · 6 comments
Assignees
Labels
area/http bug stale stalebot believes this issue/PR has not been touched recently

Comments

@qicz
Copy link
Member

qicz commented Mar 13, 2023

like envoy doc configured, use pathSeparatedPrefix and pre_rewrite is "/":

image

the pathSeparatedPrefix "/om/backend" would watch

  • /om/backend
  • /om/backend/
  • /om/backend/v1
  • /om/backend?param=true

reference envoy docs:

image

but the upstream receive double "/"

image

the pre_rewrite is not "/" work fine:

image

image

I think we should trim the double "/" when the prefix_write is "/" and the prefix is pathSeparatedPrefix.

@qicz qicz added bug triage Issue requires triage labels Mar 13, 2023
@qicz qicz changed the title the upstream receive double / the upstream receive // path Mar 13, 2023
@kyessenov kyessenov added area/http and removed triage Issue requires triage labels Mar 14, 2023
@kyessenov
Copy link
Contributor

CC @yanavlasov , seems reasonable to make rewrites produce valid paths.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 13, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2023
@qicz
Copy link
Member Author

qicz commented Apr 21, 2023

@kyessenov This issue auto closed ptal and label with no stalebot , thanks

@nxy7
Copy link

nxy7 commented Sep 6, 2023

As far as I'm aware this issue wasn't fixed, but it seems pretty fundamental for routing. Are there any plans to support this features?

@cpakulski
Copy link
Contributor

I will work on this issue/bug.

@cpakulski cpakulski self-assigned this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http bug stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

4 participants