Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection balancing after upstream connection was already created #25915

Closed
ohadvano opened this issue Mar 3, 2023 · 4 comments
Closed

Connection balancing after upstream connection was already created #25915

ohadvano opened this issue Mar 3, 2023 · 4 comments
Labels
area/connection area/listener question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@ohadvano
Copy link
Contributor

ohadvano commented Mar 3, 2023

Currently there's an option to add a connection balancer, that is invoked very early in the process chain, right after the socket accepted a new connection and before a handler for the connection is chosen. Would theoretically be possible to re-balance connections in the data processing stage? For example, during a L4/L7 filter? Would it be possible to re-balance in listener filters stage? Thanks

@ohadvano ohadvano added the triage Issue requires triage label Mar 3, 2023
@zuercher zuercher added question Questions that are neither investigations, bugs, nor enhancements area/listener area/connection and removed triage Issue requires triage labels Mar 3, 2023
@zuercher
Copy link
Member

zuercher commented Mar 3, 2023

@mattklein123 might have something to add, but this comment on the issue which led to the implementation of connection balancing says it's probably not possible: #4602 (comment)

@mattklein123
Copy link
Member

I think it would be extremely difficult to implement. Obviously, the earlier in the lifecycle it is done the easier it would theoretically be, but the main problem is that everything is effectively dispatcher local, so the minute you have anything related to the dispatcher you would have to migrate all of it somehow.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 9, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connection area/listener question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants