the libc++ build configuration does not work on recent clang versions

[jpeach]

Description:

When building envoy with --config=libc++, clang will fail to find standard C++ headers.

Repro steps:

$ CC=clang CXX=clang bazel build --config=clang --config=libc++ //source/exe:envoy-static
...
Use --sandbox_debug to see verbose messages from the sandbox clang failed: error executing command 
  (cd /home/jpeach/.cache/bazel/_bazel_jpeach/af5610e61ef13740f13f753f9b95f927/sandbox/linux-sandbox/94/execroot/envoy && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
    PWD=/proc/self/cwd \
  /usr/bin/clang -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-stdlib=libc++' -MD -MF bazel-out/host/bin/external/com_google_protobuf/_objs/protoc/main.d '-frandom-seed=bazel-out/host/bin/external/com_google_protobuf/_objs/protoc/main.o' -iquote external/com_google_protobuf -iquote bazel-out/host/bin/external/com_google_protobuf -iquote external/bazel_tools -iquote bazel-out/host/bin/external/bazel_tools -isystem external/com_google_protobuf/src -isystem bazel-out/host/bin/external/com_google_protobuf/src -isystem bazel-out/host/bin/external/envoy/bazel/foreign_cc/zlib/include -g0 -g0 -no-canonical-prefixes -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c external/com_google_protobuf/src/google/protobuf/compiler/main.cc -o bazel-out/host/bin/external/com_google_protobuf/_objs/protoc/main.o)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
In file included from external/com_google_protobuf/src/google/protobuf/compiler/main.cc:31:
external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_generator.h:40:10: fatal error: 'string' file not found
#include <string>
         ^~~~~~~~
1 error generated.
Target //source/exe:envoy-static failed to build

The problem seems to be that bazel adds the -no-canonical-prefixes flag to clang, which breaks the built-in search path behavior.

This is bazelbuild/bazel#13071. Filing the corresponding bug here to help future people trying to build envoy with libc++.

[howardjohn]

Is there a workaround for this?

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[jpeach]

not stale

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[keith]

The linked bazel issue for this has a fix merged. Is this good in envoy now?

[keith]

Actually this never was updated in rules_cc, just bazel (as usual). Which is partially why I'm working on #19760, so I bet it's not fixed