Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could envoy support specific work pthread auto bind cpu, if i start --concurrency 1 #13502

Closed
zjd87 opened this issue Oct 12, 2020 · 5 comments
Closed
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@zjd87
Copy link

zjd87 commented Oct 12, 2020

be similar to NGINX worker_processes 1; worker_cpu_affinity auto;

@zjd87 zjd87 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Oct 12, 2020
@htuch
Copy link
Member

htuch commented Oct 12, 2020

Can you please elaborate on this by explaining what Nginx does or linking to the exact part of the documentation? Thanks.

@htuch htuch added question Questions that are neither investigations, bugs, nor enhancements and removed triage Issue requires triage labels Oct 13, 2020
@zjd87
Copy link
Author

zjd87 commented Oct 13, 2020

I mean that each work thread can bind each cpu core, in case of multi work thread compete for the same cpu core

@htuch
Copy link
Member

htuch commented Oct 13, 2020

I think you are asking for CPU pinning via thread affinity. There was some discussion of this in #4602. Do you have reason to suspect that there is a real issue here?

I think this might also come up in a performance measurement context, CC @oschaaf.

@htuch htuch added help wanted Needs help! and removed question Questions that are neither investigations, bugs, nor enhancements labels Oct 13, 2020
@zjd87
Copy link
Author

zjd87 commented Oct 16, 2020

I think you are asking for CPU pinning via thread affinity. There was some discussion of this in #4602. Do you have reason to suspect that there is a real issue here?

I think this might also come up in a performance measurement context, CC @oschaaf.

#4602 should be kernel tcp reuseport, solve thundering herd and request load-balance for multi threads.
But my focus is that two or more thread maybe send interrupt signal to same cpu core in a moment, compete for a cpu core, cause that cpu utilization rate reduce; If suport CPU pinning via thread affinity such configure, maybe avoid this case.
Thank you!

@zjd87
Copy link
Author

zjd87 commented Oct 16, 2020

@htuch #13602 help me solve this question , thank you!

@htuch htuch closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants