From b7bc42064b030c6bae4998e3b1568bb0023562b9 Mon Sep 17 00:00:00 2001 From: Ryan Hamilton Date: Thu, 7 Mar 2024 02:29:48 -0800 Subject: [PATCH] http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (#32751) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including #32611 and #32401 so reverting this flag seems wise. Signed-off-by: Ryan Hamilton --- changelogs/current.yaml | 5 +++++ source/common/runtime/runtime_features.cc | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/changelogs/current.yaml b/changelogs/current.yaml index 1ce3212d3aae..eeba495907f2 100644 --- a/changelogs/current.yaml +++ b/changelogs/current.yaml @@ -11,6 +11,11 @@ behavior_changes: The runtime flag ``envoy.reloadable_features.enable_include_histograms`` is now enabled by default. This causes the ``includeHistogram()`` method on ``Stats::SinkPredicates`` to filter histograms to be flushed to stat sinks. +- area: http2 + change: | + Changes the default value of ``envoy.reloadable_features.http2_use_oghttp2`` to ``false``. This changes the codec used for HTTP/2 + requests and responses. A number of users have reported issues with oghttp2 including issue 32611 and issue 32401 This behavior + can be reverted by setting the feature to ``true``. - area: eds change: | Enabling caching caching of EDS assignments when used with ADS by default (introduced in Envoy v1.28). diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc index f709e7a24984..156053b7d181 100644 --- a/source/common/runtime/runtime_features.cc +++ b/source/common/runtime/runtime_features.cc @@ -57,8 +57,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_connection_close_header_in_redirec RUNTIME_GUARD(envoy_reloadable_features_http1_use_balsa_parser); RUNTIME_GUARD(envoy_reloadable_features_http2_decode_metadata_with_quiche); RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header); -// Ignore the automated "remove this flag" issue: we should keep this for 1 year. -RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); RUNTIME_GUARD(envoy_reloadable_features_http2_validate_authority_with_quiche); RUNTIME_GUARD(envoy_reloadable_features_http_allow_partial_urls_in_referer); RUNTIME_GUARD(envoy_reloadable_features_http_filter_avoid_reentrant_local_reply); @@ -110,6 +108,9 @@ RUNTIME_GUARD(envoy_restart_features_use_eds_cache_for_ads); // Begin false flags. Most of them should come with a TODO to flip true. +// TODO(birenroy) Flip this to true after resolving issues. +// Ignore the automated "remove this flag" issue: we should keep this for 1 year. +FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); // Execution context is optional and must be enabled explicitly. // See https://github.com/envoyproxy/envoy/issues/32012. FALSE_RUNTIME_GUARD(envoy_restart_features_enable_execution_context);