From 78567702d99b2d6e2a7140bf3dc4b0984f73878b Mon Sep 17 00:00:00 2001 From: Jose Ulises Nino Rivera Date: Mon, 1 Jul 2019 15:07:40 -0700 Subject: [PATCH] perf: update test binary size target (#212) Signed-off-by: Jose Nino jnino@lyft.com Description: after #173 landed this target broke due to the breaking API change. This target will be added to CI once #181 closes, so breakages like this will not go undected. Risk Level: low - updating API, deleting old build rules. Signed-off-by: JP Simard --- mobile/library/common/BUILD | 8 -------- mobile/test/performance/test_binary_size.cc | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/mobile/library/common/BUILD b/mobile/library/common/BUILD index a42c1f43a0ca..e2d905b844a5 100644 --- a/mobile/library/common/BUILD +++ b/mobile/library/common/BUILD @@ -22,11 +22,3 @@ cc_library( ], deps = [":envoy_main_interface_lib"], ) - -envoy_cc_binary( - name = "test_binary_size", - srcs = ["test_binary_size.cc"], - repository = "@envoy", - stamped = True, - deps = ["envoy_main_interface_lib"], -) diff --git a/mobile/test/performance/test_binary_size.cc b/mobile/test/performance/test_binary_size.cc index 322b3f8c6a52..30ee0c106358 100644 --- a/mobile/test/performance/test_binary_size.cc +++ b/mobile/test/performance/test_binary_size.cc @@ -1,8 +1,8 @@ -#include "main_interface.h" +#include "library/common/main_interface.h" // NOLINT(namespace-envoy) // This binary is used to perform stripped down binary size investigations of the Envoy codebase. // Please refer to the development docs for more information: // https://envoy-mobile.github.io/docs/envoy-mobile/latest/development/performance/binary_size.html -int main() { return run_envoy(nullptr); } +int main() { return run_envoy(nullptr, nullptr); }