Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take a comment pass through #37

Closed
junr03 opened this issue Jun 6, 2019 · 4 comments
Closed

take a comment pass through #37

junr03 opened this issue Jun 6, 2019 · 4 comments
Assignees
@goaway @rebello95 @junr03
Labels
community docs
Milestone
v0.1 "Antipasto"

Comments

@junr03
Copy link
Member

junr03 commented Jun 6, 2019

A lot of things in the codebase are not intuitive. We should take a pass on the codebase and add comments were things are not transparent. This will help with all the eyes we are getting on the repo soon.
@junr03
Copy link
Member Author

junr03 commented Jun 6, 2019

There are several things that would benefit from some love:

  1. Android demo
  2. JNI stuff
  3. bazel rules

@junr03 junr03 added the docs label Jun 6, 2019
@junr03 junr03 added this to the v0.1 "Antipasto" milestone Jun 6, 2019
@rebello95 rebello95 mentioned this issue Jun 11, 2019
Closed
@junr03 junr03 mentioned this issue Jun 13, 2019
Merged
buildbreaker pushed a commit that referenced this issue Jun 13, 2019
@junr03
comments: inline clarifications (#77)
ad9c5ed 
Signed-off-by: Jose Nino <[email protected]>

Description: inline comment pass prior to release. This is my pass at #37.
@junr03
Copy link
Member Author

junr03 commented Jun 13, 2019

First pass done in #77. @rebello95 and @goaway have expressed interest in doing another pass so I'll keep this issue open.

@rebello95
Copy link
Contributor

I think we're pretty much covered - only adding a couple more here: #85

@rebello95 rebello95 mentioned this issue Jun 13, 2019
Merged
@rebello95
Copy link
Contributor

Closing this out

@Augustyniak Augustyniak mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goaway goaway

@rebello95 rebello95

@junr03 junr03

Labels
community docs
Projects
None yet
Milestone
v0.1 "Antipasto"
Development

No branches or pull requests
3 participants
@goaway @rebello95 @junr03