New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseFieldGroup: unintentional re-render of FormContext consumers due to changed subContext object reference. #82

Open

dinony opened this issue Sep 25, 2019 · 1 comment

Labels

Milestone

v3 - Hooks improv...

dinony commented Sep 25, 2019 •

edited

Loading

BaseFieldGroup creates a new object in the render method, which updates FormContext consumers every time.

const p = {x: 2, y: 3}

Object.is({...p}, {...p})
// false

More infos in the Context API.

Maybe issue 57 also relates to this issue.

Member

maschino commented Dec 11, 2019

Should be fixed with release 3.0.0, I'll keep an eye on it.

maschino added bug FieldGroup labels

maschino added this to the v3 - Hooks improvements milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment