Buffer overrun on strcpy in parse_operand

[nihirash]

Issue #83 wasn't platform specific but was common for all platforms - buffer overrun on strcpy.

In my case buffer overrun happens here:

agon-ez80asm/src/assemble.c

Line 357 in fbc45c5

strcpy(operand->immediate_name, string);

As operand in context was calculating between two labels term_free_cmd_end - term_free_cmd(33 bytes, when maximum size was 32) - so this situation is possible for another cases too.

Simplest way move away issue - making this constant larger:

agon-ez80asm/src/config.h

Line 33 in fbc45c5

#define MAXNAMELENGTH 32 // Maximum name length of labels

Best way - check string size before copying it to resulting buffer(and increase buffer size too).

[envenomator]

This is something I can work with. Too many people are dumping their git repo URL to me, stating 'this doesn't work'. Combine this with a platform I'm not supporting (which I get lots of questions about, even when I'm not releasing binaries for these), not a good combination.

I can reproduce this issue. It happens during the operand stage, when the operand itself has a maximum of LINEMAX characters at read, while the buffer is defined as MAXNAMELENGTH. I'll fix this in the next release.

[nihirash]

Sorry, I'll try be a bit more correct next time.

[envenomator]

Fixed as part of release v1.8