Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Filter "Direction" #565

Closed
malfynnction opened this issue Jan 18, 2023 · 2 comments · Fixed by #988
Closed

Transaction Filter "Direction" #565

malfynnction opened this issue Jan 18, 2023 · 2 comments · Fixed by #988
Labels
enhancement New feature or improvements to an existing one

Comments

@malfynnction
Copy link

It would be nice to add a filter parameter direction to the transaction list.
It could have the following values:

  • "incoming": off-budget account -> on-budget account
  • "outgoing": on-budget account -> off-budget account
  • "transfer": internal account -> internal account
@malfynnction malfynnction added the enhancement New feature or improvements to an existing one label Jan 18, 2023
@morremeyer
Copy link
Member

morremeyer commented Jan 18, 2023

This is kind of related to envelope-zero/frontend#618.

We need to clearly define what we see as a transfer: Either

  • a transaction with source and destination account being on-budget, or
  • a transaction with source and destination account being internal

For the purpose of budgeting, the former is correct.

For the purpose of wording, I think income, spend and transfer are better choices since they line up with the wording we already use.

Thoughts?

@morremeyer
Copy link
Member

I'll implement this as initially proposed by @malfynnction.
If we find out that it doesn't work well, we can iterate on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvements to an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants