Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields from v3 in graphql api #412

Closed
testower opened this issue Apr 9, 2024 · 0 comments · Fixed by #475
Closed

Add new fields from v3 in graphql api #412

testower opened this issue Apr 9, 2024 · 0 comments · Fixed by #475
Labels
enhancement New feature or request
Milestone

Comments

@testower
Copy link
Collaborator

testower commented Apr 9, 2024

Is your feature request related to a problem? Please describe.

There are several new fields in v3.0 of gbfs. These should be added to our graphql api.

Goal / high level use-case

List the fields here - TBD

  • Deprecate fields that uses "bike" in name, add same fields with "vehicle" naming
  • Make and model in vehicle_types now are translated
  • system_information: deprecated "language", and add new field "languages"
  • system_information: terms_url and privacy_url are now translated
  • geofencing zones properties, name is now translated
  • geofencing zones rules setRideAllowed(rule.getRideStartAllowed() && rule.getRideEndAllowed()
  • system_information new fields: attribution_organization_name and attribution_url
  • system_information new field: opening_hours
  • Stations: deprecate vehicle_type_capacity and vehicle_capacity, add new fields vehicle_docks_capacity and vehicle_types_capacity
  • vehicle_types: deprecate eco_label, and add new field eco_labels
  • vehicle_types: add new field description
  • vehicle_types: add new fields wheel_count, max_permitted_speed, rated_power
  • vehicle_types: deprecate FormFactor "scooter"
  • system_information: add new field termination_date

Describe the solution you'd like

Note that this requires the mapping between gbfs model and entities to be rewritten to happen on top of v3 instead of v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant