Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate testing utilities into their own crate #27

Closed
fjarri opened this issue Oct 13, 2024 · 1 comment
Closed

Separate testing utilities into their own crate #27

fjarri opened this issue Oct 13, 2024 · 1 comment
Labels
API Involves backwards-incompatible changes of the public API tests Testing things
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Oct 13, 2024

In the testing submodule we have some useful utilities. It would be nice to gate them behind a feature so that regular crate users didn't need to compile that part of the code. The problem is, we use those utilities in manul's own unit-tests, and it's currently impossible to enable a feature for tests only (see rust-lang/cargo#2911).

So a possible solution is to separate the testing utilities into another crate, and use it in dev-dependencies of manul.

@fjarri fjarri added API Involves backwards-incompatible changes of the public API tests Testing things labels Oct 13, 2024
@fjarri fjarri added this to the v1.0.0 milestone Oct 14, 2024
@fjarri
Copy link
Member Author

fjarri commented Oct 16, 2024

Gated under a feature in #31. Writing doctests may be awkward, but then again, we're better off putting such tests in example. Closing for now.

@fjarri fjarri closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involves backwards-incompatible changes of the public API tests Testing things
Projects
None yet
Development

No branches or pull requests

1 participant