Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NayNay] Return all info, similar to subkey #311

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

rh0delta
Copy link
Contributor

@rh0delta rh0delta commented Nov 15, 2024

Related Issue(s)

Proposed Changes

  • updated account creation, new or imported, to return all the information a user will need to secure their account
  • updated both tui and cli to return the same information

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Screenshot 2024-11-15 at 3 00 54 PM Screenshot 2024-11-15 at 3 01 15 PM

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

- updated account creation, new or imported, to return all the information a user will need to secure their account
- updated both tui and cli to return the same information
@rh0delta rh0delta requested a review from mixmix November 15, 2024 21:26
@rh0delta rh0delta added the documentation Improvements or additions to documentation label Nov 15, 2024
@rh0delta rh0delta added this to the Function Completeness milestone Nov 15, 2024
@johnnymatthews
Copy link
Contributor

johnnymatthews commented Nov 16, 2024

Issue to track in docs here: entropyxyz/entropy-docs#263

@johnnymatthews
Copy link
Contributor

johnnymatthews commented Nov 16, 2024

Docs PR ready: entropyxyz/entropy-docs#264

@rh0delta rh0delta merged commit 1bd225a into dev Nov 17, 2024
2 checks passed
@rh0delta rh0delta deleted the naynay/account-new-all-info branch November 17, 2024 00:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
@mixmix
Copy link
Contributor

mixmix commented Nov 27, 2024

oh ... this change was a surprise for me. I'm gonna start another issue to clarify why we're doing with our CLI output, cos this is that "can I parse that easily" challenge I keep raising.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, when I generate a new key, I'd like to have all information about my newly created key
3 participants