Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferencesHelper with Enum trait containing Python keywords or builtins leads to errors #301

Open
johannesloibl opened this issue Oct 29, 2021 · 0 comments

Comments

@johannesloibl
Copy link

I stumbled upon this when defining a preferences helper for a logging configuration.
When defining an Enum trait whose values contain strings that map to Python keywords or builtins (like the logging level "Warning"):
image
Upon initialization of the preferences, the _get_value method of the PreferencesHelper class, will call an eval on "Warning", which results in a type instance of Warning. The following Enum trait validator then fails since the Warning type in not contained in the enum.
image

When specifying the default preferences like this:

[application_logger]
default_level = "Warning"

works upon loading the first app startup.
But after closing the application, the user preferences are re-written, resulting in "Warning" being dumped without ticks.

A potential solution might be executing the "eval" and then dismissing results that are builtins?

Using apptools 5.1.0, traits 6.3.1, Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant