Added authentication when pressing the Share QR, edit and delete button #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used the requestAuthentication function in utils/auth_util.dart to perform the authentication
|
|
vishnukvmd
requested changes
Oct 6, 2023
vishnukvmd
reviewed
Oct 6, 2023
lib/l10n/arb/app_en.arb
Outdated
| "minimizeAppOnCopy": "Minimize app on copy", | ||
| "editCodeAuthMessage": "Authenticate to edit code", | ||
| "deleteCodeAuthMessage": "Authenticate to delete code", | ||
| "showQRAuthMessage": "Authenticate to show QR" |
There was a problem hiding this comment.
LGTM apart from this tiny thing. Will merge once this is fixed :)
There was a problem hiding this comment.
Cool I have fixed it 🤝
vishnukvmd
approved these changes
Oct 6, 2023
|
Thanks for the contribution @ShivamHP! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added authentication when pressing the Share QR, edit and delete button in CodeWidget
Resolves #192
Used the requireAuthentication() function in utils/auth_util.dart to perform authentication
Type of Change
Enhances security