Splitting Gigantic EqualsNode into few Smaller Ones #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
4e6 and
hubertp
as code owners
JaroslavTulach
changed the title
JaroslavTulach
commented
Apr 14, 2023
JaroslavTulach
commented
Apr 14, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Ordering.enso
Outdated
Show resolved
Hide resolved
…pes are supposed to be handled on boundary. However when we see WithWarnings - we have to delegate that to EqualsComplexNode
Akirathan
approved these changes
Apr 14, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java
Outdated
Show resolved
Hide resolved
...main/java/org/enso/interpreter/node/expression/builtin/ordering/HasCustomComparatorNode.java
Outdated
Show resolved
Hide resolved
…ion/builtin/meta/EqualsNode.java Co-authored-by: Pavel Marek <[email protected]>
JaroslavTulach
force-pushed
the
wip/jtulach/MoreEqualsNodes_6191
branch
from
1711239 to
dcd484b
Compare
hubertp
approved these changes
Apr 14, 2023
...main/java/org/enso/interpreter/node/expression/builtin/ordering/HasCustomComparatorNode.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
commented
Apr 15, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/EqualsNode.java
Show resolved
Hide resolved
5 tasks
|
Assuming latest change fixes all tests, let's run benchmarks! Another benchmark run.
Comparing the two runs with today's regular run reveals just one suspicious result Performance is ready to go. |
jdunkerley
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6191 by splitting
EqualsNodeinto more smaller ones. Creating just the basic one by default and the more complex ones on demand. Expecting that for majority of usages only the basic node is enough.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
/blob/develop/docs/style-guide/rust.md) style guide.
InteropLibrarywhen==arrays, hashes, objects