No need for -- when using withDebug command

[JaroslavTulach]

Pull Request Description

I am tired of always adding -- when using withDebug command. With this change one can simply prefix:

sbt> withDebug --debugger testOnly *SomeTest

rather than having to add -- after testOnly:

sbt> withDebug --debugger testOnly -- *SomeTest

Important Notes

Both (the new as well as the old) variants remain possible however.

Checklist

Please include the following checklist in your PR:

• The documentation has been updated if necessary.
• All code conforms to the
  Scala,
  style guides.
• All code has been tested:
  • Unit tests have been written where possible.

[Akirathan]

Nice. I am looking forward to the moment once we get rid even of the annoying additional -- in, e.g., withDebug --debugger testOnly -- *EnsoCompilerTest -- -z org.enso.compiler.EnsoCompilerTest.testBench

[hubertp]

But -- is generic and with your change we hardcode the debug options so 🤷

[JaroslavTulach]

But -- is generic and with your change we hardcode the debug options so shrug

What do you mean by "hardcode"? My idea was to process all options until first that is not known to withDebug. Obviously the set of options that withDebug recognizes is fixed - but it was fixed/hardcoded all the time!

What do you mean be "generic"? Yes, -- is a POSIX way of saying: stop processing following CLI arguments as options. I am just claiming that it is not needed in this case. If withDebug arguments precede the other ones, we can easily recognize them and consume just them. -- seems unnecessary.

[hubertp]

But -- is generic and with your change we hardcode the debug options so shrug

What do you mean by "hardcode"? My idea was to process all options until first that is not known to withDebug. Obviously the set of options that withDebug recognizes is fixed - but it was fixed/hardcoded all the time!

I don't think we had something similar to isDebugFlag before. So if someone adds a debug option but forgets to add it to that match, this approach won't work.

I'm not convinced about this solution but at the same time I don't have any other proposal. It also doesn't bother me enough to reject it, so I will give a weak 👍

[Akirathan]

@JaroslavTulach I have just discovered that with sbt, you can create, e.g., $HOME/.sbtrc and put some aliases there, like:

alias dbg=withDebug --debugger testOnly --

And then, you can just start debugging with, e.g., dbg *EnsoCompilerTest. No double dashes anywhere.