-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SHA3-224 algorithm in text-buffer
by SHA1
#8662
Comments
A duplicate of #6691 I think. |
I think the scope is different. This one only implies the change of hashing algorithm in the |
Also @Akirathan, if the goal is just to remove the bouncycastle dependency, can the version calclulator use the same logic with the enso/engine/language-server/src/main/scala/org/enso/languageserver/filemanager/FileSystem.scala Lines 234 to 248 in 689c8f7
|
Ok, I see, you already did it in #8664 |
Fine, but there is a problem (at least currently) when we have to support both, old and new, GUI. They can't use different algorithms. I would say this would have to wait until old GUI is completely dropped and still will be an incompatible change. |
Or we can fix the old GUI to use SHA-1. I assume downgrading the algorithm is going to be easy. |
On hold until GUI1 is retired then we will switch to SHA1 in GUI2. |
In
text-buffer
, SHA3-224 is used for calculating the checksum of a text content -enso/lib/scala/text-buffer/src/main/scala/org/enso/text/Sha3_224VersionCalculator.scala
Line 11 in 689c8f7
According to the original author, @4e6, there is no reason to use specifically SHA3-224, so we can just use the simpler SHA-1.
Note that this change also requires modifications to some gui parts.
Related to:
The text was updated successfully, but these errors were encountered: