Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric operators not searchable by the operator and have no display ports #6854

Open
radeusgd opened this issue May 25, 2023 · 4 comments
Open
Labels

Comments

@radeusgd
Copy link
Member

2 (possibly related) issues with numeric operators:
image

When I have a number node and press tab, I want to create an operation on numbers.

  1. When I type / to create a 'division' the searcher does not show a / operator - which is there.

Interestingly, if I search by the Alias - start typing divide, it will show up:
image

However, after selecting that method from CB and creating a new node, the node does not show an input port for the second number argument:

image

I would expect an input port on the right-hand-side of the / operator here.

The same happens for other kinds of operators:
image

As a side note, if I want to search by name, the - can be found by typing Subtract. However, typing Minus does not find it. IMO it should also be searchable by minus.

@kazcw
Copy link
Contributor

kazcw commented May 25, 2023

Fixing the missing ports is blocked on backend support: #6374

@farmaazon
Copy link
Contributor

When I type / to create a 'division' the searcher does not show a / operator - which is there.

It not literally true, as the operator is there: it's just on the top of Base.Data section. We just do not filter by / and there is a reason for that:

If one write + or \, they already typed their operation and want to add operands now. Thus, it felt sensible to show all suggestions to pick potential operand instead displaying suggestion of operator which in 99% is already complete at this point.

Now, the only sensible improvement I can think of is treating spaces as parts of the operator; so if the user types 2 + without a trailing space, we can assume we're still typing the operator. The question is how often user would prefer to make "partially applied operations", like foo +2.

@farmaazon farmaazon added s-info-needed Status: more information needed from submitter g-component-browser x-design p-low Low priority and removed triage labels May 26, 2023
@farmaazon farmaazon self-assigned this May 26, 2023
@farmaazon farmaazon added this to the Beta Release milestone Jun 5, 2023
@farmaazon
Copy link
Contributor

farmaazon commented Jun 26, 2023

Copied from #7105 a comment by @wdanilo :

If the user types <, the Component Browser should indeed hint something starting or containing <. No reaction from Component Browser is indeed a bad behavior. Just a small explanation.

@wdanilo could you somehow refer to my doubts in the comment above? And how it would work when user types 2+ (without any spaces)? I think they could expect suggestions for second operand (what's the point of displaying a single suggestion for + at this point)?

@jdunkerley jdunkerley added p-medium Should be completed in the next few sprints and removed p-low Low priority labels Sep 1, 2023
@jdunkerley
Copy link
Member

Still an issue with newest CB - we should be able to find operators when typing.

@jdunkerley jdunkerley added p-high Should be completed in the next sprint and removed p-medium Should be completed in the next few sprints labels Sep 11, 2023
@farmaazon farmaazon added p-low Low priority and removed p-high Should be completed in the next sprint labels Sep 25, 2023
@AdRiley AdRiley removed this from the Beta Release milestone Feb 19, 2024
@farmaazon farmaazon added -gui and removed s-info-needed Status: more information needed from submitter -gui labels Feb 23, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 23, 2024
@farmaazon farmaazon removed their assignment Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📤 Backlog
Development

No branches or pull requests

5 participants