Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling log files in verbose mode #6789

Closed
hubertp opened this issue May 22, 2023 · 2 comments
Closed

Rolling log files in verbose mode #6789

hubertp opened this issue May 22, 2023 · 2 comments
Assignees
Labels
-compiler -tooling Category: tooling
Milestone

Comments

@hubertp
Copy link
Collaborator

hubertp commented May 22, 2023

Motivation

Attempts to reproduce many of the reported bugs typically come down to one question - do we have the logs? So far regular logs are not so helpful because we need them in very verbose mode to observe the exchanges between IDE and the engine.
This is problematic because we have to ask users to either run in verbose mode constantly (can slow down the performance) or kill the current session and try to reproduce the problem with verbose logs (and likely fail).

Proposed solution

Currently, we always log files to enso log file folder. But logs in trace level are very verbose and therefore not turned on by default.
The proposition is to use rolling log files.

@hubertp
Copy link
Collaborator Author

hubertp commented May 22, 2023

It seems like we have our own implementation of log writer in https://github.com/enso-org/enso/blob/develop/lib/scala/logging-service/src/main/scala/org/enso/loggingservice/printers/FileOutputPrinter.scala.
That's a bit unfortunate since I was hoping that I would be able to just use something that is already present.

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board May 23, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone May 30, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Aug 1, 2023
@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Aug 29, 2023
@hubertp
Copy link
Collaborator Author

hubertp commented Sep 5, 2023

This is done with the work on #7253

@hubertp hubertp closed this as completed Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -tooling Category: tooling
Projects
Archived in project
Development

No branches or pull requests

2 participants