Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep links do not work on Linux #6147

Closed
2 tasks
somebody1234 opened this issue Mar 30, 2023 · 11 comments
Closed
2 tasks

Deep links do not work on Linux #6147

somebody1234 opened this issue Mar 30, 2023 · 11 comments
Labels
--bug Type: bug

Comments

@somebody1234
Copy link
Contributor

Discord username

No response

What type of issue is this?

Permanent – Ocurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

Deep links (enso:// links) are not registered on Linux, and hence the links open in a regular browser (the default fallback on my setup, at least)

Expected behaviour

Deep links open in the electron app

How we can reproduce it?

  1. Open the electron app
  2. Try logging in with Google

Screenshots or screencasts

No response

Enso Version

latest

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

Linux

Operating System Version

No response

Hardware you are using

No response

@farmaazon
Copy link
Contributor

farmaazon commented Mar 30, 2023

I haven't made extensive research yet, but I'm afraid every desktop environment (GNOME vs KDE vs whatever else) is doing it in a bit different way, similarly to the file bindings. I would not recommend our application to do it on Linux by itself. As a Linux user myself, I really don't like if an application meddles with those settings on startup.

Except there is some standard for AppImages, but as I heard from @mwu-tow there is hardly a unified standard for installing app images on various distros.

@somebody1234
Copy link
Contributor Author

supposedly app.setAsDefaultProtocolClient should Just Do It on Linux - at least, the docs mention limitations for macos and windows but not linux.
that said, i'm not sure whether just that call would be sufficient

@somebody1234
Copy link
Contributor Author

oh, apparently that function doesn't work/isn't required on linux? (link)

@somebody1234
Copy link
Contributor Author

re: lack of a unified standard, that does make sense
however i do think there needs to be some way to make deep linking work on linux, since it's pretty much vital for making -authentication for the cloud dashboard work

@somebody1234
Copy link
Contributor Author

currently i'm manually extracting the .desktop and installing it in ~/.local/share/applications/, and chaning the Exec command to /path/to/binary %U, however that's not working very well as the binary does not accept the url as a command-line argument. not sure how deep links are normally sent to linux electron apps though...

@farmaazon
Copy link
Contributor

however i do think there needs to be some way to make deep linking work on linux, since it's pretty much vital for making -authentication for the cloud dashboard work

That's actually important information. Have you a task for it, so we can put this as a blocker of that? And do you need it for Design Partners/Beta release?

@wdanilo
Copy link
Member

wdanilo commented Mar 31, 2023

Ugh, this is bad that it's breaking user-logging. Hmm, @mwu-tow is working on very related thing right now - registering on different systems file associations. @mwu-tow what do you think of this issue?

And yes, @farmaazon, being able to run the app and log-in on linux is unfortunately needed for Design Partners :(

@farmaazon farmaazon added the -gui label Mar 31, 2023
@mwu-tow
Copy link
Contributor

mwu-tow commented Mar 31, 2023

IIRC, we mentioned this issue on Wednesday when talking with @PabloBuchu, and the thought was to have authentication disabled on Linux at first. Yes, it's likely pretty much a similar issue as file associations.

See #5239

@wdanilo
Copy link
Member

wdanilo commented Mar 31, 2023

@mwu-tow @farmaazon @PabloBuchu I was talking with Sylwia about it. @PabloBuchu can we do it this way that on linux users would need to copy-paste some code instead for now instead of using deep links?

@somebody1234
Copy link
Contributor Author

oh, i guess this is pretty much a duplicate of #5239

@4e6 4e6 removed the triage label Apr 4, 2023
@4e6
Copy link
Contributor

4e6 commented Apr 4, 2023

Duplicate of #5239

@4e6 4e6 marked this as a duplicate of #5239 Apr 4, 2023
@4e6 4e6 closed this as completed Apr 4, 2023
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

5 participants