Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to compare branches to bench_download tool #6110

Closed
3 tasks
Akirathan opened this issue Mar 28, 2023 · 2 comments · Fixed by #6198
Closed
3 tasks

Add ability to compare branches to bench_download tool #6110

Akirathan opened this issue Mar 28, 2023 · 2 comments · Fixed by #6198
Assignees
Labels
-tooling Category: tooling p-high Should be completed in the next sprint x-new-feature Type: new feature request

Comments

@Akirathan
Copy link
Member

tools/performance/engine-benchmarks/bench_download.py tool, introduced in #5852, should provide functionality to compare two (or more?) branches. This will be useful when one wants to ensure that the changes on their PR won't cause any regressions after merging to develop.

Tasks

Preview Give feedback
@Akirathan Akirathan added -tooling Category: tooling x-new-feature Type: new feature request labels Mar 28, 2023
@Akirathan
Copy link
Member Author

I would like to implement this before #5998.

@Akirathan Akirathan moved this from ❓New to 📤 Backlog in Issues Board Mar 28, 2023
@Akirathan Akirathan self-assigned this Mar 28, 2023
@Akirathan Akirathan added the p-high Should be completed in the next sprint label Apr 4, 2023
@Akirathan Akirathan moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 4, 2023
@Akirathan Akirathan linked a pull request Apr 4, 2023 that will close this issue
5 tasks
@enso-bot
Copy link

enso-bot bot commented Apr 4, 2023

Pavel Marek reports a new STANDUP for today (2023-04-04):

Progress: Trying to add functionality to display more than one branch in the graphs, but gave that up after some struggling with Google charts and Jinja. I have at least created a PR where one can use --compare option that compares two benchmark runs from GH. It should be finished by 2023-04-06.

@mergify mergify bot closed this as completed in #6198 Apr 5, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tooling Category: tooling p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant