Propagate Component Browser Selections to Source and Disassociate the Node That Is Edited by the Searcher From any Changes Not Made by the Searcher

[wdanilo]

This task is automatically imported from the old Task Issue Board and it was originally created by Michael Mauderer.
Original issue is here.

---

Why

As an Enso User
I want the node that is being edited by the Searcher not to be changed, except by my input, but I do want to see the preview of the visualization show the result of the example selected in the component browser.
So that I can thee the preview of the selection but not loose mu input.

Acceptance Criteria

Scenario: 
GIVEN there is a Searcher open and editing a node
WHEN I select an example from the Componet Browser
THEN the visualisation gets updates, but not the input area where I am typing. 
WHEN I start typing in the Expression Input
THEN the visualization shows value of selected component result, not the input changes.

Comments:

Michael Mauderer reports a new STANDUP for yesterday (2022-08-22):

Progress: Started working on #182633967 and noticed that the core feature already works and was able to start working on a prototype of the next task right away. The old task was deleted/skipped. It should be finished by 2022-08-26.

Next Day: Next day I will be working on the ##182634050 task. Fix edge cases and errors that appear in the current "quick and dirty" test of the visualisation preview. (Enso Bot - Aug 23, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for yesterday (2022-08-23):

Progress: Updated open PRs and made ready to review/QA. Continued cleaning up the implementation of the preview and fixing issues. It should be finished by 2022-08-26.

Next Day: Next day I will be working on the ##182634050 task. Fix last small issues around preview updates and check that aborting editing correctly reverts everything in the scene. (Enso Bot - Aug 24, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-08-24):

Progress: Fixed last small issues with the preview. PR should be ready tomorrow. Still need to check that revert correctly works in all cases. It should be finished by 2022-08-26.

Next Day: Next day I will be working on the ##182634050 task. Clean branch for PR. Ensure that bug about reverting nodes after editing is fixed. (Enso Bot - Aug 24, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-08-25):

Progress: Still working on some bugs about syncing input field and AST when aborting editing. It should be finished by 2022-08-26.

Next Day: Next day I will be working on the ##182634050 task. Hopefully fix last issues and clean up code, open PR. (Enso Bot - Aug 25, 2022)

---

**Michael Mauderer** reports a new **🔴 DELAY** for today (2022-08-28):

Summary: There is 4 days delay in implementation of the Propagate Component Browser Selections to Source and Disassociate the Node That Is Edited by the Searcher From any Changes Not Made by the Searcher (#182634050) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days weekend.

Delay Cause: Investigating and fixing an (existing) issue with syncing the controller presenter and graph editor took some extra time. (Enso Bot - Aug 28, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-08-28):

Progress: Found the underlying issue that prevented the syncing between controller presenter and graph editor, and came up with a solution that I still need to finish implementing and testing. This is also what is causing #182926584 It should be finished by 2022-08-30.

Next Day: Next day I will be working on the ##182634050 task. Finish implementing the fix for syncing views and make sure it is working and covering all corner cases. (Enso Bot - Aug 28, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-08-29):

Progress: Fixed the sync issue but this introduced a new issue with searcher selections that now needs to be addressed. Working on a fix, but will most likely only be finished tomorrow. It should be finished by 2022-08-30.

Next Day: Next day I will be working on the ##182634050 task. Apply the fix for the selection issue, check everything is working and open PR. (Enso Bot - Aug 29, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-08-30):

Progress: Found the cause of the sync issue, and applied a fix, but it seems that still has knock on effects. So I'm further untangling the interactions that happen here between the (graph|searcher)+(presenter|controller|view). It should be finished by 2022-08-30.

Next Day: Next day I will be working on the ##182634050 task. Fix the fix for the bug. (Enso Bot - Aug 30, 2022)

---

**Michael Mauderer** reports a new **🔴 DELAY** for today (2022-08-30):

Summary: There is 2 days delay in implementation of the Propagate Component Browser Selections to Source and Disassociate the Node That Is Edited by the Searcher From any Changes Not Made by the Searcher (#182634050) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Investigating and fixing the interaction between controller presenter and graph editor takes some extra time. (Enso Bot - Aug 30, 2022)

---

**Michael Mauderer** reports a new **🔴 DELAY** for today (2022-09-05):

Summary: There is 5 days delay in implementation of the Propagate Component Browser Selections to Source and Disassociate the Node That Is Edited by the Searcher From any Changes Not Made by the Searcher (#182634050) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: 2 days weekend + 3 days COVID-19 (Enso Bot - Sep 5, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-09-05):

Progress: Tracked down the cause of the current issue about syncing the node view of the searcher controlled input field, during editing. Started to work out a fix for it. It should be finished by 2022-09-06.

Next Day: Next day I will be working on the ##182634050 task. Finish implementing the fix for updating the internal representation of the view to be consistent with the searcher input view. Open PR for the whole task. (Enso Bot - Sep 5, 2022)

---

**Michael Mauderer** reports a new **STANDUP** for today (2022-09-06):

Progress: Fixed the outstanding issue. But its a but its a bit too late to trust myself with the last cleanup and testing, so I will finalise the PR tomorrow. It should be finished by 2022-09-06.

Next Day: Next day I will be working on the ##182634050 task. Open PR for current vis preview task, and move on to next task. I will also be filing the new task for lazy text visualisation for discussion. (Enso Bot - Sep 6, 2022)

---

**Acceptance/QA** review set to **pass** (Adam Obuchowicz - Sep 16, 2022)

---

Commit by Michael Mauderer https://github.com/enso-org/enso/commit/545e1d7ce9a364771b64fbbb63cfe5a6f0f0cfcf enso

Show Visualisation Preview when Selecting Item on Searcher (#3691)

Implements #182634050.

Enables visualization previews for selections in the searcher.

Works for the old Searcher and the new Component Browser, but it was easier to show the examples for the old searcher, as the suggestions seem to be better/faster available currently (this will improve with the new implementation using better strings and the new GridView).

Peek.2022-09-07.12-59.mp4

Aborting an edit now also correctly reverts a node.

https://user-images.githubusercontent.com/1428930/188898549-ddd41294-2571-4e2e-b6d5-909cbf71de04.mp4 (Michael Mauderer - Sep 16, 2022)

---