Reconcile getModules
With Library Preloading
#1863
Labels
p-high
Should be completed in the next sprint
getModules
With Library Preloading
#1863
Summary
Once the imports started to be done lazily, the
getModules
method may return None for modules that do exist but are simply not loaded.One example of this causing issues was visualizations not loading their context modules, which was quick-fixed by adding the explicit
ensurePackageIsLoaded
before executing the visualization (#1857).Another potential point for problems is the
openFile
endpoint (seeOpenFileCmd
) - if the module the file is bound to is not found, it will most likely fail to open that file properly (or worse, although now I think this should not happen, associate it with an empty module and lead to clashes when that module is actually loaded).We need to go through all usages of
getModule
and consult each of them with a team member responsible for a given component to analyse if it should try to preload the module first or not.Possibly, we may just implement a 'catchall' solution that just always ensures that the module is preloaded on each
getModule
call, but we need to analyse if it is safe to do so.Value
Specification
getModule
, most likely on a call with @iamrecursion, @4e6 and @kustosz and analyse what is the right decision for each of them (if they should try to preload libraries if it was not yet loaded).Acceptance Criteria & Test Cases
The text was updated successfully, but these errors were encountered: