Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Manager Should Prioritize Bundled Runtime #1645

Closed
4e6 opened this issue Apr 2, 2021 · 1 comment · Fixed by #1651
Closed

Project Manager Should Prioritize Bundled Runtime #1645

4e6 opened this issue Apr 2, 2021 · 1 comment · Fixed by #1651
Assignees
Labels
p-medium Should be completed in the next few sprints

Comments

@4e6
Copy link
Contributor

4e6 commented Apr 2, 2021

General Summary

The project manager bundle uses local JVM runtime located at ~/.local/share/enso/runtime even if the bundled one is available:

.
├── bin
│   └── project-manager
├── dist
│   └── 0.5.19
├── runtime
│   └── graalvm-ce-java11-21.0.0.2
└── THIRD-PARTY

Steps to Reproduce

  1. Download the project-manager bundle (tested with a 0.5.19 staging release

  2. Extract and start the project manager

  3. Run the IDE with --no-backend flag

    ./enso-linux-2.0.0-alpha.2.AppImage --dev --no-backend
    
  4. ps shows that the language server is using the local JVM runtime

    $ ps -ef | grep java
    dbushev   298050  297863 65 17:29 pts/8    00:02:00 /home/dbushev/.local/share/enso/runtime/graalvm-ce-java11-21.0.0.2/bin/java -Dpolyglot.engine.IterativePartialEscape=true -Dtruffle.class.path.append=/home/dbushev/Downloads/enso-project-manager-0.5.19-linux-amd64/enso/dist/0.5.19/component/runtime.jar -jar /home/dbushev/Downloads/enso-project-manager-0.5.19-linux-amd64/enso/dist/0.5.19/component/runner.jar --logger-connect ws://localhost:39415/ --server --root-id 45be41b5-9c64-42e9-bac3-a359fc6661b9 --path /home/dbushev/enso/projects/Test_R --interface 127.0.0.1 --rpc-port 59015 --data-port 61124 --log-level info
    
  5. If you remove the local runtime, the project manager starts using the bundled one.

Expected Result

The project manager uses the bundled JVM runtime even if the local one is available.

Actual Result

The project manager always uses local JVM runtime if available.

Enso Version

main @ 117ca51

@4e6 4e6 added Type: Bug p-medium Should be completed in the next few sprints labels Apr 2, 2021
@iamrecursion
Copy link
Contributor

The project manager is doing what is globally correct. The issue is that we don't enable the launcher to download python and graal into the runtimes it downloads, but we should.

@4e6 4e6 self-assigned this Apr 6, 2021
@4e6 4e6 closed this as completed in #1651 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-medium Should be completed in the next few sprints
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants