Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Lazy Visualization Support for Tables #1583

Closed
5 tasks
radeusgd opened this issue Mar 16, 2021 · 0 comments
Closed
5 tasks

Full Lazy Visualization Support for Tables #1583

radeusgd opened this issue Mar 16, 2021 · 0 comments
Assignees
Labels
p-high Should be completed in the next sprint

Comments

@radeusgd
Copy link
Member

Summary

While #1582 implements basic visualization support for the databases, it only allows to fetch a limited numbers of rows from the database. It however does not allow lazily loading more rows.

To implement that feature it must be possible to add an OFFSET to the query (apart from LIMIT).

Value

  • The IDE can implement the fully featured lazy visualizations.

Specification

  • Research what guarantees OFFSET gives us in SQL.
    • Is it deterministic enough in most implementations to be used for the use-case (lazily loading visualizations) we need? If not, we may need to materialize the whole query and have laziness only within sending data from the in-memory dataframe.
  • Implement code-gen for OFFSET.
  • Add slice operation and others to Database.Table.
  • Update the visualization preprocessor to support the offset.

Acceptance Criteria & Test Cases

  • The OFFSET codegeneration and materialization is tested.
@radeusgd radeusgd added Type: Enhancement p-high Should be completed in the next sprint labels Mar 16, 2021
@radeusgd radeusgd self-assigned this Mar 16, 2021
@wdanilo wdanilo closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

No branches or pull requests

2 participants