Project Rename Request Is Not Correctly Validated

[mwu-tow]

General Summary

Calling project/rename with a name that is not a valid referent name succeeds. This tricks IDE into thinking that the project was actually renamed into whatever the user typed, while the underlying name is different. This leads to further issues, like visualizations not working after rename.

Steps to Reproduce

Open any project in IDE, rename to a invalid identifier, like FooBarr.

See the websocket log.

{"jsonrpc":"2.0","id":0,"method":"project/list","params":{"numberOfProjects":null}} | 83 | 11:39:02.756
{"jsonrpc":"2.0","id":0,"result":{"projects":[{"name":"Unnamed","id":"4f7582e9-d02a-4602-824f-cdaa8aaf2395","engineVersion":"0.2.6","lastOpened":"2021-03-08T10:37:29.8014162Z"},{"name":"Import_Test","id":"1c01cbea-6837-4e5d-a8b1-ab305478b7b1","engineVersion":"0.2.6","lastOpened":"2021-03-08T09:47:23.603224Z"},{"name":"Trams_Project","id":"cc690e57-277e-4793-9086-e25693625412","engineVersion":"0.2.1","lastOpened":null}]}} | 424 | 11:39:02.775
{"jsonrpc":"2.0","id":1,"method":"project/open","params":{"missingComponentAction":"Install","projectId":"4f7582e9-d02a-4602-824f-cdaa8aaf2395"}} | 145 | 11:39:02.864
{"jsonrpc":"2.0","id":1,"result":{"engineVersion":"0.2.6","languageServerJsonAddress":{"host":"127.0.0.1","port":52272},"languageServerBinaryAddress":{"host":"127.0.0.1","port":65131}}} | 185 | 11:39:06.156
{"jsonrpc":"2.0","id":2,"method":"project/rename","params":{"name":"FooBarr","projectId":"4f7582e9-d02a-4602-824f-cdaa8aaf2395"}} | 129 | 11:41:14.164
{"jsonrpc":"2.0","id":2,"result":null}

Expected Result

Call should fail with ProjectNameValidationError.

Actual Result

Call succeeds, renaming project to Foo_Barr — which is not what was requested.

Enso Version

For example:

    Enso Project Manager
    Version:    0.2.6
    Built with: scala-2.13.5 for GraalVM 21.0.0.2
    Built from: enso-0.2.6 @ aec61292c467c3c52e2259ac9e8cd03670c77f15
    Built on:   Windows 10 (amd64)