Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Editor Widget - Parse cells to make proper column types. #11434

Closed
Tracked by #11183
farmaazon opened this issue Oct 29, 2024 · 3 comments · Fixed by #11612
Closed
Tracked by #11183

Table Editor Widget - Parse cells to make proper column types. #11434

farmaazon opened this issue Oct 29, 2024 · 3 comments · Fixed by #11612
Assignees
Labels

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Oct 29, 2024

The Table Input widget should use Table.input method instead of Table.new because the latter will parse strings to proper column types.

@farmaazon
Copy link
Contributor Author

Refinement notes:

  • Make a meeting with James again to ask for special Table constructor which just takes list of strings and parses them correctly. That's better in multiuser approach.

@farmaazon
Copy link
Contributor Author

Refinement notes II:

  • existing Table.new would not match Table Input Widget anymore: will just fall back to "array" widget.
  • Numbers should be put as strings. If the numbers are in the existing code, the widget should not match. Nothings should be supported as before.

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Nov 14, 2024
@vitvakatu vitvakatu self-assigned this Nov 20, 2024
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Nov 20, 2024
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Nov 21, 2024
@enso-bot
Copy link

enso-bot bot commented Nov 21, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-11-20):

Progress: Addressing review comments in various PRs, using Table.input instead of Table.new for table input widgets. It should be finished by 2024-11-20.

@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🗄️ Archived
Development

Successfully merging a pull request may close this issue.

3 participants