Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of multiple session/initProtocolConnection messages #10495

Closed
hubertp opened this issue Jul 9, 2024 · 1 comment
Closed
Labels
--bug Type: bug -gui

Comments

@hubertp
Copy link
Collaborator

hubertp commented Jul 9, 2024

The problem is best illustrated with the exchange between GUI and LS:
Screenshot from 2024-07-09 15-57-23

  1. LS is slow to respond to connection initialization requests
  2. GUI makes a few attempts to get the connection
  3. Eventually, session is initialized and GUI receives a (late) reply
  4. Further requests receive the already initialized error response, as per protocol specification

It seems that GUI's handling is incorrect. It should respect the already initialized connection response and either continue or close the connection first. Retrying the same request is not going to change the response.

This is blocking #9789.

Note that the repercussions of the current logic are that the project is unusable:

Cannot load initial suggestion database. Continuing with empty suggestion database: Language Server request 'session/initProtocolConnection' failed: Session already initialised
@farmaazon
Copy link
Contributor

Closing in favor of #9347 (which is same bug and estimated)

@farmaazon farmaazon closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Jul 10, 2024
@sylwiabr sylwiabr removed the triage label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui
Projects
Archived in project
Development

No branches or pull requests

3 participants