Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run Oracle GraalVM benchmarks on manually scheduled GH Actions #10255

Closed
Akirathan opened this issue Jun 12, 2024 · 1 comment
Closed
Assignees
Labels
-compiler -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints

Comments

@Akirathan
Copy link
Member

Engine benchmarks GH Action and Standard library benchmarks GH Action both have two jobs - one that runs benchmarks on GraalVM CE and other one that runs on Oracle GraalVM. The jobs run sequentially, that is how GH Actions work. This is OK for daily benchmark runs, but not for benchmarks that are manually scheduled. When manually scheduling, GraalVM CE benchmarks are sufficient.

Let's add another option along with dry-run benchmarks option:
image
that will be something like "Run only on GraalVM CE".

The changes should be done somewhere along these lines:
https://github.com/enso-org/enso/blob/develop/.github/workflows/engine-benchmark.yml#L13

@Akirathan Akirathan added d-easy Difficulty: little prior knowledge required -tooling Category: tooling p-medium Should be completed in the next few sprints -compiler labels Jun 12, 2024
@Akirathan Akirathan self-assigned this Jun 12, 2024
@Akirathan Akirathan moved this from ❓New to 📤 Backlog in Issues Board Jun 12, 2024
@Akirathan
Copy link
Member Author

Fixed by #10829 that removed Oracle GraalVM benchmarks both from daily jobs, and from jobs scheduled manually.

@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

No branches or pull requests

1 participant