Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ydoc should be a separate JPMS module #10155

Closed
1 task
Akirathan opened this issue Jun 3, 2024 · 4 comments · Fixed by #10156
Closed
1 task

ydoc should be a separate JPMS module #10155

Akirathan opened this issue Jun 3, 2024 · 4 comments · Fixed by #10156
Assignees
Labels
--bug Type: bug -compiler p-high Should be completed in the next sprint

Comments

@Akirathan
Copy link
Member

Akirathan commented Jun 3, 2024

Currently, org.enso.syntax2.Parser is present both in runtime.jar and in runner.jar. This causes issues with the class being loaded by two class loaders. Let's remove that class from these fat jars, and provide it as a separate module on module-path. Also consider providing a separate ydoc-server module (currently, ydoc-server classes are inside runner.jar).

Priority is high, as it blocks cloud's integration of ydoc-server

Tasks

Preview Give feedback

Related:

@Akirathan Akirathan added p-high Should be completed in the next sprint --bug Type: bug -compiler labels Jun 3, 2024
@Akirathan Akirathan self-assigned this Jun 3, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jun 3, 2024
@Akirathan Akirathan moved this from ❓New to 🔧 Implementation in Issues Board Jun 3, 2024
@Akirathan Akirathan changed the title Deduplicate Parser class ydoc should be a separate JPMS module Jun 3, 2024
@enso-bot
Copy link

enso-bot bot commented Jun 3, 2024

Pavel Marek reports a new STANDUP for today (2024-06-03):

Progress: - ydoc-server is a separate module - #10156

  • engine-distribution, language-server tests and runtime-integrations tests are all fixed, now testing ydoc
    • Debugging an issue "Cannot load suggestions from stdlib". Is this related to my changes?
  • Having engine-runner as a separate module would help tremendously with the sbt mess.

@enso-bot
Copy link

enso-bot bot commented Jun 4, 2024

Pavel Marek reports a new STANDUP for today (2024-06-04):

Progress: - Testing AppImage locally with ydoc

  • ydoc seems to work and synchronize files correctly.
  • Suggestions cache are still not loading. Turns out this is because helidon forbids serialization and reflection.
    • Let's fix this by serializing SuggestionsCache with our Peristance API. It should be finished by 2024-06-06.

@enso-bot
Copy link

enso-bot bot commented Jun 6, 2024

Pavel Marek reports a new STANDUP for yesterday (2024-06-05):

Progress: - Fixed Suggestions cache loading

  • Fixing failing tests because of newly introduced modules
  • Fixing native image builds It should be finished by 2024-06-06.

@enso-bot
Copy link

enso-bot bot commented Jun 6, 2024

Pavel Marek reports a new STANDUP for today (2024-06-06):

Progress: - Tested ydoc with the IDE and everything seems fine.

  • Fixing rest of the tests - there are a lot of failures as tests cannot be started because of the new modules. It should be finished by 2024-06-06.

@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -compiler p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant