-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support IPNS in contenthashes + show the stored content string even if wrong #358
Comments
That's pending on Jim's PR on multicodec to be merged multiformats/multicodec#136 . Once done, then we need to ask https://github.com/pldespaigne/content-hash to support IPNS |
Note that Are you sure you want to allow that type of pointer in ENS? Are there any docs about this policy? |
@makoto pldespaigne/content-hash#30 is done. (disclaimer: I'm not involved in any development. I just registered my ENS domain and was surprised that I can't use IPNS hash) |
@makoto pinging just to ask if there are any plans to support this. This is a must-have feature and having a first-hand support on the ENS app would be awesome 😄 |
adding some additional context: Uniswap recently migrated its interface entirely to IPFS (https://uniswap.org/blog/ipfs-uniswap-interface/). as part of this transition, the contenthash of |
we know that this domain is using an IPNS hash (not IPFS)
https://manager.ens.domains/name/www.wealdtech.eth (on mainnet)
can we support it and make it show?
cc @makoto
In any case, if the content inserted is wrong we should still show what it is, and show the warning sign that it is malformed. right now it can't be "debugged" by a user of the manager
The text was updated successfully, but these errors were encountered: