Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @enonic/react-component RichText component to render macros serverside #829

Closed
ComLock opened this issue May 2, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working Feature

Comments

@ComLock
Copy link
Contributor

ComLock commented May 2, 2023

processHtml will turn macros into html comments
Enonic XP post processing will turn html comments into actual html

Guillotine does something
https://developer.enonic.com/docs/guillotine/stable/usage#macros

Hopefully we have some JS API for this...

They where close :) #128
Related security issues? #33

@ComLock ComLock self-assigned this May 2, 2023
@ComLock
Copy link
Contributor Author

ComLock commented May 2, 2023

@ComLock
Copy link
Contributor Author

ComLock commented May 3, 2023

I can confirm that clientSide rendering fails, and that SSR works (probably transformed by Enonic XP (https://developer.enonic.com/docs/xp/stable/framework/http#http-response)

Hydration seems to work, I suspect as soon there is some effects/state it will overwrite SSR with the html comment, but I have not confirmed this yet.

@ComLock ComLock added Feature bug Something isn't working labels May 3, 2023
@ComLock ComLock removed their assignment Mar 12, 2024
@alansemenov alansemenov changed the title Render macros server-side so props contain finished html, not html comments Use @enonic/react-component RichText component to render macros serverside Oct 29, 2024
@ComLock ComLock self-assigned this Oct 29, 2024
@ComLock ComLock closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feature
Projects
None yet
Development

No branches or pull requests

1 participant