Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pass-style): don't rely on Remotable in Far docs #2191

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

dckc
Copy link
Contributor

@dckc dckc commented Mar 29, 2024

refs:

Description / Documentation Considerations

The 1st bit of SDK used in the 1st sample app in our docs is Far.

https://github.com/Agoric/dapp-offer-up/blob/cbf3836dff05e95220a201f930430a10ce960ce3/contract/src/offer-up.contract.js#L22

likewise the "hello world" contract in smart contract basics.

Far's JSDoc was in terms of Remotable. I don't think folks using Far need to know about Remotable so much.

There's momentum to skip Far and teach exo's from the start (Agoric/documentation#1033) but we're not there yet.

Security / Scaling / Testing / Compatibility / Upgrade Considerations

n/a

@dckc dckc requested review from kriskowal, erights and gibson042 March 29, 2024 16:51
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about @example. Cool!

LGTM, thanks.

@dckc dckc enabled auto-merge (rebase) March 29, 2024 22:59
@dckc dckc merged commit 0788474 into master Mar 29, 2024
18 checks passed
@dckc dckc deleted the dc-far-doc branch March 29, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants